Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the ability to disable the index_files #211

Merged
merged 1 commit into from
Dec 25, 2013

Conversation

abraham1901
Copy link
Contributor

No description provided.

@jfryman
Copy link
Contributor

jfryman commented Dec 25, 2013

Makes sense. undef and templates always is a pain. However, this way loses the safety cast that is being done with Array the line below. What happens if a string is passed now? String# doesn't have a count argument.

What do you think?

@abraham1901
Copy link
Contributor Author

What happens if a string is passed now?

Already checked.

manifests/resource/vhost.pp
155 validate_array($index_files)

@jfryman
Copy link
Contributor

jfryman commented Dec 25, 2013

I actually meant it from a different angle - I'm reluctant to change the interface abruptly for users without some amount of deprecation warning. So, the value today accepts both a string and an array. I'm okay with deprecating the string input, but that needs to come over time (doesn't need to be long, but maybe a release or two [a month? - this is arbitrary]). This value needs to be able to process both a string and array for today.

@jfryman
Copy link
Contributor

jfryman commented Dec 25, 2013

Lol. Ignore me. I see what you're saying. I didn't realize this was already changed. 😁

jfryman pushed a commit that referenced this pull request Dec 25, 2013
Fixed the ability to disable the index_files
@jfryman jfryman merged commit d5ecd53 into voxpupuli:master Dec 25, 2013
@abraham1901
Copy link
Contributor Author

tnx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants